Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display user dates in the resource detail subheader #10817

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Apr 16, 2024

Summary

This adds the user last login, disabled in, & deleted in values to the user detail page.

Fixes #10820

Occurred changes and/or fixed issues

  • Adds new fields to the DetailTop of users detail page

Technical notes summary

Adding a customized suffix via the formatterOpts feels a little clunky, but it's sufficient for customizing the display format so that we can more closely match the design. Alternatives probably include building a new formatter, but this is too much given what we are trying to achieve.

Areas or cases that should be tested

  • Users Details Page

Areas which could experience regressions

  • Users Details Page

Screenshot/Video

user-last-login

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@github-actions github-actions bot added this to the v2.8.patch1 milestone Apr 16, 2024
@rak-phillip rak-phillip marked this pull request as ready for review April 16, 2024 21:00
@rak-phillip rak-phillip marked this pull request as draft April 16, 2024 21:03
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip marked this pull request as ready for review April 19, 2024 20:28
@rak-phillip rak-phillip merged commit 4702807 into rancher:release-2.8.patch1 Apr 25, 2024
13 checks passed
@rak-phillip rak-phillip deleted the feature/user-detail-dates branch April 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants