-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/2.7.patch1/10890 last login #10903
Merged
rak-phillip
merged 7 commits into
rancher:release-2.7.patch1
from
rak-phillip:backport/2.7.patch1/10890-last-login
May 7, 2024
Merged
Backport/2.7.patch1/10890 last login #10903
rak-phillip
merged 7 commits into
rancher:release-2.7.patch1
from
rak-phillip:backport/2.7.patch1/10890-last-login
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
codyrancher
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mantis-toboggan-md
approved these changes
May 6, 2024
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
rak-phillip
commented
May 7, 2024
@@ -66,7 +66,7 @@ describe('Users', { tags: '@adminUser' }, () => { | |||
|
|||
// usersPo.goTo(); | |||
usersPo.waitForPage(); | |||
usersPo.list().elementWithName(userBaseUsername).should('be.visible'); | |||
usersPo.list().elementWithName(userBaseUsername).should('exist'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I encountered issues with tests failing because elements being rendered outside of the viewport
This element <tr.main-row> is not visible because its content is being clipped by one of its parent elements, which has a CSS property of overflow: hidden, scroll or auto
Using exist
fixes the problem.
mantis-toboggan-md
approved these changes
May 7, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR handles backports the following issues into
release-2.7.patch1
:Fixes #10891
Fixes #10890
Fixes #10889
Occurred changes and/or fixed issues
Details for each issue can be found in the associated issues for each PR. Overall, this backport handles the following:
Screenshot/Video
Checklist