Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/2.7.patch1/10890 last login #10903

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Apr 29, 2024

Summary

This PR handles backports the following issues into release-2.7.patch1:

Fixes #10891
Fixes #10890
Fixes #10889

Occurred changes and/or fixed issues

Details for each issue can be found in the associated issues for each PR. Overall, this backport handles the following:

  • Adds new fields to the users table (Last Login, Disabled In, Deleted In)
  • Adds new fields to the users detail page (Last Login, Disabled In, Deleted In)

Screenshot/Video

last-login-2 8

user-last-login

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@github-actions github-actions bot added this to the v2.7.patch1 milestone Apr 29, 2024
@rak-phillip rak-phillip marked this pull request as ready for review April 29, 2024 20:54
@gaktive gaktive requested a review from codyrancher May 2, 2024 17:43
Copy link
Contributor

@codyrancher codyrancher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to confirm that all of the columns are available after setting the global settings.

image

By any chance is Disable In meant to mean Deactivate In?
image

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@@ -66,7 +66,7 @@ describe('Users', { tags: '@adminUser' }, () => {

// usersPo.goTo();
usersPo.waitForPage();
usersPo.list().elementWithName(userBaseUsername).should('be.visible');
usersPo.list().elementWithName(userBaseUsername).should('exist');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I encountered issues with tests failing because elements being rendered outside of the viewport


This element <tr.main-row> is not visible because its content is being clipped by one of its parent elements, which has a CSS property of overflow: hidden, scroll or auto

Using exist fixes the problem.

@rak-phillip rak-phillip merged commit 10c19fa into rancher:release-2.7.patch1 May 7, 2024
5 checks passed
@rak-phillip rak-phillip deleted the backport/2.7.patch1/10890-last-login branch May 7, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants