Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port changes from release-2.8.patch1 to master #11262

Merged
merged 12 commits into from
Jun 22, 2024

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Jun 18, 2024

Summary

This ports features from release-2.8.patch1 into master to ensure that all changes introduced in the patch1 branch are present for upcoming releases.

closes #10819
closes #10642
closes #10892
closes #10980
closes #11073
closes #11077

List of PRs associated with this merge

https://github.com/rancher/dashboard/pulls?q=is%3Apr+author%3Arak-phillip+is%3Aclosed+milestone%3Av2.8.patch1

Occurred changes and/or fixed issues

All changes introduces from the following PRs should be represented in this change:

Technical notes summary

The rebase PR has been omitted:

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rak-phillip
Copy link
Member Author

@mantis-toboggan-md we will need to test this change against a v2.8.5 backend as we work on porting the whole feature into 2.9

@rak-phillip rak-phillip added this to the v2.9.0 milestone Jun 18, 2024
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox
Copy link
Member

@rak-phillip i couldn't see where this PR resolves #11013, would you be able to confirm?

@rak-phillip
Copy link
Member Author

@richard-cox #11013 inadvertently got pulled in with the forward porting effort for user retention. Removing the link from this PR.

@rak-phillip
Copy link
Member Author

The remainder of the linked issues are accurate after giving them a review.

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip merged commit e750be9 into rancher:master Jun 22, 2024
26 checks passed
@rak-phillip rak-phillip deleted the chore/port-2.9.patch1 branch September 8, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment