Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by raw value instead of string value #10818

Merged

Conversation

rak-phillip
Copy link
Member

@rak-phillip rak-phillip commented Apr 16, 2024

Summary

This ensures that the Last Login, Disabled In, & Deleted In columns in the Users table are sorted by their epoch time values instead of the string representation.

Fixes #10821

Occurred changes and/or fixed issues

  • Updates the sort key for userLastLogin, userDisabledIn, & userDeletedIn

Areas or cases that should be tested

  • Sorting of the users table

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Phillip Rak <rak.phillip@gmail.com>
@rak-phillip rak-phillip self-assigned this Apr 16, 2024
@rak-phillip rak-phillip added this to the v2.8.patch1 milestone Apr 16, 2024
@rak-phillip rak-phillip marked this pull request as ready for review April 16, 2024 20:34
Copy link
Member

@mantis-toboggan-md mantis-toboggan-md left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rak-phillip rak-phillip merged commit 5236f00 into rancher:release-2.8.patch1 Apr 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants