Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port drone build tasks to gh workflows + actions #10874

Merged
merged 3 commits into from
May 1, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 25, 2024

Summary

Fixes #10633

Occurred changes and/or fixed issues

  • Remove old drone build tasks (note - FOSSA will not be ported at this time, discussed in slack)
  • create generic setup composit action which can be used by multiple workflows
  • create generic lint, i18n-lint and unittest composit actions which can be used by multiple workflows
  • create generic build-and-upload workflow which can be used by multiple workflows
  • create workflow to trigger build-and-upload on merge to specific branch
  • create workflow to trigger build-and-upload on specific tags

Also

  • changed name of yarn target install:ci as it was used outside of ci

Note

  • I'd have liked to group together the workflows used by the build, but things like workflow subfolders aren't supported

Examples

building from branch (with uploaded bits) - https://github.com/rancher/dashboard/actions/runs/8832322713
building from tag (with uploaded bit) - https://github.com/rancher/dashboard/actions/runs/8832309261

Technical notes summary

  • branch builds aka 'hosted' builds provide a dist folder of the dashboard who's index.html is referenced in rancher setting ui-dashboard-index and used by rancher for the ui
    • hosted builds will also make the same output as embedded, this might be just for testing / validation
  • tag builds aka 'embedded' builds provide a tar.gz of the dashboard build which is picked up by the rancher build, unpacked and embedded into it
    • embedded builds will also make the same output as hosted, this might be just for testing / validation
  • rancher/ui pr - Port drone build tasks to gh workflows + actions ui#5140

Areas or cases that should be tested

  • Validation of tar.gz on tag
  • Validation of dist folder on branch
  • Merges to master should upload to latest. Merges to other branches should upload to <branch name>
  • Merges to only master, release-x or *-dev should trigger builds, no other

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

- Remove old drone build tasks (note - FOSSA will not be ported at this time, discussed in slack)
- create generic setup composit action which can be used by multiple workflows
- create generic lint, i18n-lint and unittest composit action which can be used by multiple workflows
- create generic build-and-upload workflow which can be used by multiple workflows
- trigger build-and-upload on merge to specific branch (TBD)
- trigger build-and-upload on specific tags

Also
- changed name of yarn install:ci as it was used outside of ci

Note
- I'd have liked to group together the workflows used by the build, but things like workflow subfolders
aren't supported
package.json Outdated Show resolved Hide resolved
scripts/build-hosted Outdated Show resolved Hide resolved
@richard-cox richard-cox force-pushed the richard-drone-dashboard-pr branch 2 times, most recently from 3ec34e1 to 0df4a95 Compare April 26, 2024 12:19
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit f459aa9 into rancher:master May 1, 2024
25 checks passed
@richard-cox richard-cox deleted the richard-drone-dashboard-pr branch May 1, 2024 14:25
richard-cox added a commit to richard-cox/dashboard that referenced this pull request May 13, 2024
…oard-pr

Port drone build tasks to gh workflows + actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rancher/dashboard: Move from Drone to Github Actions
2 participants