Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port drone build tasks to gh workflows + actions #5140

Merged
merged 3 commits into from
May 1, 2024
Merged

Port drone build tasks to gh workflows + actions #5140

merged 3 commits into from
May 1, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 23, 2024 •
edited
Loading

Proposed changes

  • Remove old drone build tasks (FOSSA will not be ported at this time, discussed in slack)
  • create generic 'setup' composite action which can be used by multiple workflows
  • create generic build-and-upload workflow which can be used by multiple workflows
    • remove dapper + use build script directly
    • tidy up build script
  • create workflow to build from specific branch (triggers build-and-upload)
  • create workflow to build from specific tags (triggers build-and-upload)

Linked Issues

rancher/dashboard#10635

Further comments

Examples

rancher/dashboard pr rancher/dashboard#10874

@richard-cox richard-cox added this to the v2.9.0 milestone Apr 23, 2024
@richard-cox richard-cox self-assigned this Apr 23, 2024
@richard-cox
Port drone build tasks to gh workflows + actions
a93d652 
- Remove old drone build tasks (note - FOSSA will not be ported at this time, discussed in slack)
- create generic 'setup' compostie action which can be used by multiple workflows
- create generic build-and-upload workflow which can be used by multiple workflows
- trigger build-and-upload on merge to specific branch (TBD)
- trigger build-and-upload on specific tags
@richard-cox richard-cox mentioned this pull request Apr 25, 2024
Merged
7 tasks
richard-cox
richard-cox commented Apr 26, 2024
View reviewed changes
scripts/build-static Outdated Show resolved Hide resolved
richard-cox
richard-cox commented Apr 26, 2024
View reviewed changes
scripts/ci

if [[ "${BUILD_LATEST}" == "true" ]]; then
echo "Building latest..."
./scripts/build-static -l -v latest2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test once merged

richard-cox
richard-cox commented Apr 26, 2024
View reviewed changes
scripts/gcs_upload_asset Outdated Show resolved Hide resolved
richard-cox
richard-cox commented May 1, 2024
View reviewed changes
.github/workflows/build-release.yaml Outdated
@@ -2,7 +2,7 @@ name: Build (Release)
on:
push:
tags:
- v2.9.*
- v*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v[2-9].*

nwmac
nwmac approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 52dd792 into rancher:master May 1, 2024
2 checks passed
@richard-cox richard-cox deleted the richard-drone-ui-pr branch May 1, 2024 10:40
richard-cox added a commit that referenced this pull request May 20, 2024
@richard-cox
Merge pull request #5140 from richard-cox/richard-drone-ui-pr
daeb57a 
Port drone build tasks to gh workflows + actions
@richard-cox richard-cox mentioned this pull request May 20, 2024
Merged
richard-cox added a commit to richard-cox/ui that referenced this pull request May 20, 2024
@richard-cox
Merge pull request rancher#5140 from richard-cox/richard-drone-ui-pr
ba18935 
Port drone build tasks to gh workflows + actions
This was referenced May 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees

@richard-cox richard-cox

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac