Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port drone build tasks to gh workflows + actions #5140

Merged
merged 3 commits into from
May 1, 2024

Conversation

richard-cox
Copy link
Member

@richard-cox richard-cox commented Apr 23, 2024

Proposed changes

  • Remove old drone build tasks (FOSSA will not be ported at this time, discussed in slack)
  • create generic 'setup' composite action which can be used by multiple workflows
  • create generic build-and-upload workflow which can be used by multiple workflows
    • remove dapper + use build script directly
    • tidy up build script
  • create workflow to build from specific branch (triggers build-and-upload)
  • create workflow to build from specific tags (triggers build-and-upload)

Linked Issues

rancher/dashboard#10635

Further comments

Examples

rancher/dashboard pr rancher/dashboard#10874

@richard-cox richard-cox added this to the v2.9.0 milestone Apr 23, 2024
@richard-cox richard-cox self-assigned this Apr 23, 2024
- Remove old drone build tasks (note - FOSSA will not be ported at this time, discussed in slack)
- create generic 'setup' compostie action which can be used by multiple workflows
- create generic build-and-upload workflow which can be used by multiple workflows
- trigger build-and-upload on merge to specific branch (TBD)
- trigger build-and-upload on specific tags
scripts/build-static Outdated Show resolved Hide resolved

if [[ "${BUILD_LATEST}" == "true" ]]; then
echo "Building latest..."
./scripts/build-static -l -v latest2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test once merged

scripts/gcs_upload_asset Outdated Show resolved Hide resolved
@@ -2,7 +2,7 @@ name: Build (Release)
on:
push:
tags:
- v2.9.*
- v*
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v[2-9].*

Copy link
Member

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox richard-cox merged commit 52dd792 into rancher:master May 1, 2024
2 checks passed
@richard-cox richard-cox deleted the richard-drone-ui-pr branch May 1, 2024 10:40
richard-cox added a commit that referenced this pull request May 20, 2024
Port drone build tasks to gh workflows + actions
richard-cox added a commit to richard-cox/ui that referenced this pull request May 20, 2024
Port drone build tasks to gh workflows + actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants