Paginated Label Select Fixes #11510
Merged
Paginated Label Select Fixes #11510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### No Options Shown - Ensure all ResourceLabeledSelect attributes reach LabelSelect component - This worked at some point, but $attrs now does not contain values that are defined as component props ### Cannot `Load More` options - `Pages` param Missing in API response - This has been removed, work around added ### Search term isn't matching partial results - ensure exact filter matching is off
aalves08
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Codewise and testing, LGTM @richard-cox !
Not in the video, but I also tested the partial text search and it worked. I also created a lot of pods (160) and went through the pagination with both server-side pagination on and off and didn't find any problems.
Screen.Recording.2024-07-23.at.15.40.19.mov
Merged
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11507
Occurred changes and/or fixed issues
No Options Shown
Cannot
Load MoreoptionsPagesparam Missing in API responseSearch term isn't matching partial results
Technical notes summary
pagesparam was on the old api, seeking clarrification if it's never been there on the new api (not sure how i missed it) or it was recently removedAreas or cases that should be tested
Areas which could experience regressions
Checklist