-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire in pagination to LabeledSelect and use for pods, secrets and configmaps #10786
Merged
richard-cox
merged 31 commits into
rancher:master
from
richard-cox:pagination-findall-configmaps
May 30, 2024
Merged
Wire in pagination to LabeledSelect and use for pods, secrets and configmaps #10786
richard-cox
merged 31 commits into
rancher:master
from
richard-cox:pagination-findall-configmaps
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts
- Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes
- fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534
…dall-secret-backup
- Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings
… form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled
This was referenced Apr 11, 2024
- Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response
- previously all pods were fetched... and we scrapped all container names from them - this is a scaling nightmare, user now must just enter the name/s to match
a701841
to
9afb8db
Compare
7 tasks
codyrancher
previously approved these changes
May 23, 2024
richard-cox
commented
May 24, 2024
richard-cox
commented
May 24, 2024
…most of the complexity
@codyrancher I updated given a recommendation from Neil to wrap some of the repeated / tricky code in a new component. Description's been updated, would you be able to take another look? |
codyrancher
approved these changes
May 29, 2024
nwmac
approved these changes
May 30, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #10781Supersedes #10068
Summary
Contributes to #9964
Occurred changes and/or fixed issues
ResourceLabelSelect
)LabelSelect
directly)options
collection to LabelSelectproviders
to select a secretUX changes (after design review)
Technical notes summary
Areas or cases that should be tested
With both performance pagination setting and feature flag off
Matches
tab -->Limit to specific container names
should be empty, and accept any number of free text entriesOutput
--> Access --> Credentials from Secret should show secretsLimit to specific nodes
The above should be repeated with the performance pagination setting and feature flag on
Areas which could experience regressions
Screenshot/Video