-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
330ab61
to
17f1004
Compare
&& gem install --file 'C:\fluentd\install\Gemfile' \ | ||
&& gem sources --clear-all | ||
|
||
RUN powershell -Command $ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance we can merge all the RUN
? So that we can reduce the layer of the fluentd image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dockerfile is reference from fluentd's dockerfile, in order to sync with fluentd, I prefer we do like they do. https://github.com/fluent/fluentd-docker-image/blob/master/v1.6/windows/Dockerfile
LGTM |
gem 'windows-pr' | ||
|
||
# Input / Output plugins: | ||
gem 'fluent-plugin-elasticsearch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not specify the version requirement for plugins like we did for Linux?
package/windows/Gemfile
Outdated
gem 'fluent-plugin-rewrite-tag-filter' | ||
|
||
# third party | ||
# gem 'zookeeper' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this useless?
Linux is going to upgrade versions, the version will specify in gemfile.lock. Here are the related linux PR #14 |
LGTM |
We need to remove all |
Problem: Logging feature hasn't supported in windows yet Solution: Add logging windows supported Issue: http://github.com/rancher/rancher/issues/20510
LGTM |
Problem:
windows cluster not support logging yet
Solution:
add build windows fluentd image related files