This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Support windows logging #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aiwantaozi
force-pushed
the
windows
branch
2 times, most recently
from
330ab61
to
17f1004
Compare
orangedeng
reviewed
Jul 12, 2019
| && gem install --file 'C:\fluentd\install\Gemfile' \ | ||
| && gem sources --clear-all | ||
|
|
||
| RUN powershell -Command $ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue'; \ |
There was a problem hiding this comment.
Is there any chance we can merge all the RUN? So that we can reduce the layer of the fluentd image.
There was a problem hiding this comment.
The dockerfile is reference from fluentd's dockerfile, in order to sync with fluentd, I prefer we do like they do. https://github.com/fluent/fluentd-docker-image/blob/master/v1.6/windows/Dockerfile
|
LGTM |
gitlawr
reviewed
Aug 6, 2019
| gem 'windows-pr' | ||
|
|
||
| # Input / Output plugins: | ||
| gem 'fluent-plugin-elasticsearch' |
There was a problem hiding this comment.
Why not specify the version requirement for plugins like we did for Linux?
package/windows/Gemfile
Outdated
| gem 'fluent-plugin-rewrite-tag-filter' | ||
|
|
||
| # third party | ||
| # gem 'zookeeper' |
|
Linux is going to upgrade versions, the version will specify in gemfile.lock. Here are the related linux PR #14 |
|
LGTM |
|
We need to remove all |
Problem: Logging feature hasn't supported in windows yet Solution: Add logging windows supported Issue: http://github.com/rancher/rancher/issues/20510
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
windows cluster not support logging yet
Solution:
add build windows fluentd image related files