-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
Hello @aiwantaozi! I found that Gemfile.lock is actually not used because only Gemfile copied to container. Line 28 in 4a4bce7
Is it bug or feature?) |
8c430a3
to
ae665e1
Compare
@@ -38,10 +39,6 @@ RUN BUILD_DEPS="make ruby-dev build-essential autoconf automake libtool libsnapp | |||
libjemalloc1 \ | |||
ruby \ | |||
&& echo 'gem: --no-document' >> /etc/gemrc \ | |||
&& gem install --file Gemfile \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this removed? Without this command you will get /run.sh: 23: exec: /usr/local/bin/fluentd: not found
when running container.
package/Dockerfile
Outdated
&& gem install --file Gemfile \ | ||
&& apt-get purge -y --auto-remove \ | ||
-o APT::AutoRemove::RecommendsImportant=false \ | ||
$BUILD_DEPS \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this is also must be preserved to make image smaller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we need it, will update pr and remove WIP after fully test
05550f4
to
9ea77ef
Compare
Problem: current elasticsearch gems has warning log for elasticsearch 7.x Solution: upgrade fluentd, elasticsearch etc gems version Issue: rancher/rancher#20450 rancher/rancher#20509
9ea77ef
to
b0720f9
Compare
Should we add |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Problem:
current elasticsearch gems has warning log for elasticsearch 7.x
Solution:
upgrade fluentd, elasticsearch etc gems version
Issue:
rancher/rancher#20450
rancher/rancher#20509