This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
upgrade gems version #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aiwantaozi! I found that Gemfile.lock is actually not used because only Gemfile copied to container. Line 28 in 4a4bce7 Is it bug or feature?) |
aiwantaozi
force-pushed
the
enhance-upgrade
branch
from
8c430a3
to
ae665e1
Compare
kinolaev
reviewed
Aug 5, 2019
| @@ -38,10 +39,6 @@ RUN BUILD_DEPS="make ruby-dev build-essential autoconf automake libtool libsnapp | |||
| libjemalloc1 \ | |||
| ruby \ | |||
| && echo 'gem: --no-document' >> /etc/gemrc \ | |||
| && gem install --file Gemfile \ | |||
There was a problem hiding this comment.
Why this removed? Without this command you will get /run.sh: 23: exec: /usr/local/bin/fluentd: not found when running container.
kinolaev
reviewed
Aug 5, 2019
package/Dockerfile
Outdated
| && gem install --file Gemfile \ | ||
| && apt-get purge -y --auto-remove \ | ||
| -o APT::AutoRemove::RecommendsImportant=false \ | ||
| $BUILD_DEPS \ |
There was a problem hiding this comment.
I think, this is also must be preserved to make image smaller.
There was a problem hiding this comment.
Hi, we need it, will update pr and remove WIP after fully test
aiwantaozi
force-pushed
the
enhance-upgrade
branch
3 times, most recently
from
05550f4
to
9ea77ef
Compare
Problem: current elasticsearch gems has warning log for elasticsearch 7.x Solution: upgrade fluentd, elasticsearch etc gems version Issue: rancher/rancher#20450 rancher/rancher#20509
aiwantaozi
force-pushed
the
enhance-upgrade
branch
from
9ea77ef
to
b0720f9
Compare
|
Should we add |
|
LGTM |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
current elasticsearch gems has warning log for elasticsearch 7.x
Solution:
upgrade fluentd, elasticsearch etc gems version
Issue:
rancher/rancher#20450
rancher/rancher#20509