-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.7] Deprecate hosted provisioning, nodescaling tests and bump rancher/shepherd version to 8ffe7983dc26 #45585
[v2.7] Deprecate hosted provisioning, nodescaling tests and bump rancher/shepherd version to 8ffe7983dc26 #45585
Conversation
Signed-off-by: Parthvi <parthvi.vala@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, could you also provide the same fix for the nodescaling tests for the hosted clusters? Will approve afterwards.
Signed-off-by: Parthvi <parthvi.vala@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the calls to the extensions since they will cause build errors.
Is it alright if I update the dependency in the same PR? |
Signed-off-by: Parthvi <parthvi.vala@suse.com>
Signed-off-by: Parthvi <parthvi.vala@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
Hosted Provisioning test cases are already tested in rancher/hosted-providers-e2e repo, so it has been decide to deprecate these tests and mark them as skip.