Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7] Deprecate hosted provisioning, nodescaling tests and bump rancher/shepherd version to 8ffe7983dc26 #45585

Conversation

valaparthvi
Copy link
Contributor

Summary:

Hosted Provisioning test cases are already tested in rancher/hosted-providers-e2e repo, so it has been decide to deprecate these tests and mark them as skip.

Signed-off-by: Parthvi <parthvi.vala@suse.com>
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you also provide the same fix for the nodescaling tests for the hosted clusters? Will approve afterwards.

Signed-off-by: Parthvi <parthvi.vala@suse.com>
Copy link
Contributor

@markusewalker markusewalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the calls to the extensions since they will cause build errors.

@valaparthvi
Copy link
Contributor Author

remove the calls to the extensions since they will cause build errors.

Is it alright if I update the dependency in the same PR?

Signed-off-by: Parthvi <parthvi.vala@suse.com>
Signed-off-by: Parthvi <parthvi.vala@suse.com>
@valaparthvi valaparthvi changed the title [v2.7] Deprecate hosted provisioning tests [v2.7] Deprecate hosted provisioning, nodescaling tests and bump rancher/shepherd version to 8ffe7983dc26 May 24, 2024
Copy link
Contributor

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@valaparthvi valaparthvi merged commit e9f830d into rancher:release/v2.7 May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants