Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7] Modify hosted provider create methods to not read directly from config file #199

Merged

Conversation

valaparthvi
Copy link
Contributor

This PR modifies the hosted provider create functions to not read directly from the CATTLE_TEST_CONFIG file but obtain the data instead as a user input. This makes the functions more generic and useful when the user needs to run parallel test and the config file needs to be modified during the test, these changes will help in avoiding race condition with the resource.

Note: This is a breaking change PR.

…g file

Signed-off-by: Parthvi <parthvi.vala@suse.com>
@valaparthvi
Copy link
Contributor Author

Marked the test using these methods as deprecated/skip on rancher/rancher.
rancher/rancher#45585

Copy link

@igomez06 igomez06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igomez06 igomez06 merged commit 8ffe798 into rancher:release/v2.7 May 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants