[v2.9/Main] Modify hosted provider create methods to not read directly from config file #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g file Signed-off-by: Parthvi <parthvi.vala@suse.com>
anupama2501
reviewed
May 21, 2024
igomez06
approved these changes
May 22, 2024
valaparthvi
changed the title
Based on the slack discussion, we will mark the test cases in rancher/rancher as |
As pointed out with @markusewalker the scaling tests need to be deprecated as well. @valaparthvi we need two approvals for a a merge just an FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the hosted provider create functions to not read directly from the CATTLE_TEST_CONFIG file but obtain the data instead as a user input. This makes the functions more generic and useful when the user needs to run parallel test and the config file needs to be modified during the test, these changes will help in avoiding race condition with the resource.
Note: This is a breaking change PR.