Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to rke up with external-aws. node lookup fails if user doesn't set both internal-address and hostname-override #3445

Closed
slickwarren opened this issue Nov 30, 2023 · 2 comments
Assignees
Milestone

Comments

@slickwarren
Copy link

RKE version:
v1.5.0-rc11

Docker version: (docker version,docker info preferred)

Operating system and kernel: (cat /etc/os-release, uname -r preferred)

Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)

cluster.yml file:
using aws nodes, set the public IP address and the following in the yaml:

cloud_provider:
  name: "external-aws"
  useInstanceMetadataHostname: true

Steps to Reproduce:

Results:
the cluster fails to come up, stating that the first node is not able to be found in the logs
FATA[0402] [ "<ip>" not found]

In an offline discussion with @kinarashah , this appears to be due to the following:
internal address should be set
hostname-override should be set to the aws hostname that works with external-aws

@kinarashah
Copy link
Member

kinarashah commented Dec 1, 2023

The root cause is that RKE fails to find the node if both internal address and hostname override are empty. External address is not available to RKE at this stage of provisioning because it's populated by aws cloud controller manager after it is deployed. There are 2 options:

  1. Set internal address https://github.com/kinarashah/rke/blob/a74c388690524b9190dc1449a1bb154fdeb77bdc/k8s/node.go#L65
  2. Set hostname meeting the node conventions for out of tree cloud provider
    https://github.com/kinarashah/rke/blob/a74c388690524b9190dc1449a1bb154fdeb77bdc/k8s/node.go#L56

@jiaqiluo
Copy link
Member

The fix was validated in RKE v1.5.0-rc11 per comments in rancher/rancher#43624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants