Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fixed stream server bind address for cri-dockerd #3656

Closed
kinarashah opened this issue Aug 14, 2024 · 3 comments
Closed

use fixed stream server bind address for cri-dockerd #3656

kinarashah opened this issue Aug 14, 2024 · 3 comments

Comments

@kinarashah
Copy link
Member

Currently RKE doesn't set streaming-bind-addr when starting cri-dockerd:
https://github.com/rancher/rke-tools/blob/f90a8996c5f2143b7b62a07444eb47f962354bad/entrypoint.sh#L118

Fix it to set it to a known address, preferably to the same address 127.0.0.1:10010 as other runtimes do (for reference: k3s-io/k3s#9975)

Will need a change in RKE too if users can configure streaming-bind-addr, else the fix in rke-tools will suffice. Note that the change would be applied on kubelet restarts.

SURE-8866

@vardhaman22
Copy link
Contributor

vardhaman22 commented Sep 6, 2024

testing scenarios:

  1. Creation from rancher and rke should set the default port (10010)
  2. Upgrading (from july to august) on rancher should also set the default port(10010)
  3. And setting the custom host port on an installed version should update them in the cluster
    @kinarashah please suggest if anything else needs to be tested for this.

@vivek-shilimkar
Copy link

Tested the scenario 1 and 3 with rancher v2.9-head and rke version 1.6.2-rc1. Both the scenarios set the port as expected.

@rishabhmsra
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants