Leader election: do not wait 2 hours for retry, even in dev mode #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Silvio Moioli <silvio@moioli.net>
rmweir
approved these changes
Oct 28, 2022
cmurphy
approved these changes
Nov 4, 2022
|
I'm going to merge and label issue as dev validate. |
moio
added a commit
to moio/fleet
that referenced
this pull request
Nov 30, 2022
Main motivation is to get rancher/wrangler#232 Leader election: do not wait 2 hours for retry, even in dev mode Signed-off-by: Silvio Moioli <silvio@moioli.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it useful to leverage the
CATTLE_DEV_MODEenvironment variable in order to make leader leases last longer - this is pretty much needed when attaching a debugger (eg. via delve) - else the process is automatically killed after some seconds.Problem with
CATTLE_DEV_MODEin that scenario is, at the moment, that it also elongates the retry period, which means the initial leader election at process start will also take two hours, which is a bit impractical.This PR tries to address the issue by elongating all times but the retry period - I tested it manually and it works great for delve debugging.
Related: #234
Issue: rancher/rancher#39506