Moving linting to GitHub Actions #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinJoiner
approved these changes
Feb 28, 2023
The GitHub Action can display, right in the code (i.e. PR), where the lint issue is at. This can provide more direct feedback to PR authors. Signed-off-by: Matt Farina <matt.farina@suse.com>
mattfarina
force-pushed
the
gha-golanglint-ci
branch
from
c23d15a
to
cd3c802
Compare
|
Not against CI, but want to confirm we can use github actions in all repos/orgs we own to be consistent. |
|
@cbron Having talked with both @macedogm and @jeff-hobbs, GitHub Actions should be fine to use for now. |
|
@cbron I also spoke with EIO who is very good with GitHub Actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub Action can display, right in the code (i.e. PR), where the lint issue is at. This can provide more direct feedback to PR authors.
Note, dependabot will create PRs for the GitHub Action but not for the version of the linter that's specified in the configuration.