Side Effect Free and Nondeterministic Method List Generator w/ ASM #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mernst
requested changes
Mar 2, 2020
| @@ -974,7 +992,8 @@ public void runCollectionGenerationTest() { | |||
| options, | |||
| "collectiongen.Day.valueOf(java.lang.String) exclude", | |||
| "collectiongen.AnInputClass.hashCode() ignore", | |||
| "collectiongen.Day.values() ignore"); | |||
| "collectiongen.Day.values() ignore", | |||
| "collectiongen.AnInputClass.toString() ignore"); | |||
There was a problem hiding this comment.
I'm concerned by the addition of ignores in these small tests. Why are the given methods no longer being called? We should investigate each of these changes carefully. (Did you already do that, or just accept the changes?)
There was a problem hiding this comment.
I think we discussed this in an email (though we only got to investigating one of them).
| @@ -1498,8 +1520,8 @@ public void runBadCollectionSizeTest() { | |||
| systemTestEnvironmentManager.createTestEnvironment("bad-collection-size"); | |||
| RandoopOptions options = createRandoopOptions(testEnvironment); | |||
| options.addTestClass("collections.BadCollection"); | |||
| options.setOption("generated_limit", "10"); | |||
| options.setOption("output_limit", "10"); | |||
| options.setOption("generated_limit", "5"); | |||
There was a problem hiding this comment.
I think we discussed this in an email (though we only got to investigating one of them).
mernst
reviewed
Mar 21, 2020
mernst
reviewed
Mar 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tool generates the SideEffectFree and Nondeterministic method lists from checker framework and Rashmi's work on determinism.