Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New icon #185

Closed
jebeld17 opened this issue Jun 4, 2019 · 7 comments
Closed

New icon #185

jebeld17 opened this issue Jun 4, 2019 · 7 comments

Comments

@jebeld17
Copy link

jebeld17 commented Jun 4, 2019

SharpKeys is in need of a new, modern icon.

(UPDATE: Please see below, along with Pull Request #186)

@jebeld17
Copy link
Author

jebeld17 commented Jun 4, 2019

I put together a quick addition for the SharpKeys program as a brand new, modern icon, inspired by Fluent Design. Take a look below:
Icon

With that, SharpKeys also gets a new logo:
SharpKeys_Logo

Other attachments:
Assets.zip

@jebeld17
Copy link
Author

jebeld17 commented Jun 4, 2019

See Pull Request 186:
#186

@randyrants
Copy link
Owner

I had to close the PR because there's no way to make SharpKeys a Microsoft Store app; if you are interested in submitting a new logo, please work it into the Win32 codebase, which I think requires an ICO file.

Thanks!

@jebeld17
Copy link
Author

jebeld17 commented Jun 5, 2019

My Pull Request did so and swapped out the .ICO file.
In addition, Microsoft now allows full-privileged Desktop Apps into the Microsoft Store.

@jebeld17
Copy link
Author

jebeld17 commented Jun 5, 2019

See Pull Request #187

@randyrants
Copy link
Owner

The last meeting I went for this called out that while Win32 apps were supported there were still restrictions in place to protect critical parts of the system which included HKLM. I'll ask around on campus and see if that's still the case and check WACK. I started trying to get this into the Store 18 months ago, so it's not because I don't want it - it's because it wasn't supported.

@randyrants randyrants reopened this Jun 5, 2019
@randyrants
Copy link
Owner

Sadly, the policy is unchanged: https://docs.microsoft.com/en-us/windows/msix/desktop/desktop-to-uwp-prepare

These three in particular:

  • Your application always runs with elevated security privileges. - SharpKeys has to elevate itself to write to the Registry Key that Windows uses to remap things.
  • Your application modifies the HKEY_LOCAL_MACHINE (HKLM) registry hive. - SharpKeys has to write to this hive because Windows does not respect any remapped keys when written to HKCU. It's been tried: doesn't work.
  • Your application writes to the AppData folder or to the registry with the intention of sharing data with another app. - while SharpKeys isn't trying to put content in the Registry to share the data with other apps, Windows still needs to find the Value and there's no way it's looking in AppData.

Unless there's something that changed with VS 2019, this is the most recent information out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants