Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qualified_predicate #234

Open
cbizon opened this issue Apr 2, 2024 · 4 comments
Open

Add qualified_predicate #234

cbizon opened this issue Apr 2, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@cbizon
Copy link
Contributor

cbizon commented Apr 2, 2024

When we make an inferred edge for the increases/decreases activity or abundance queries, we should be adding a qualified predicate = causes to the edge. See NCATSTranslator/Feedback#744

@cbizon cbizon self-assigned this Apr 2, 2024
@cbizon cbizon added this to the Octopus milestone Apr 2, 2024
@cbizon
Copy link
Contributor Author

cbizon commented Apr 11, 2024

So ARAGORN is just taking the input qgraph edge and copying it into the inferred edge. The qualified_predicate isn't in the qgraph, so it doesn't get onto the inferred edge.

Either 1) It does get added to the qgraph, in which case, it will automatically show up in the result BUT we'll need to be sure that we still recognize it as an MVP2 query or
2) It doesn't get added in the qgraph and we need to special case it (bleah).

Either way, pushing to Eel

@cbizon
Copy link
Contributor Author

cbizon commented Jul 12, 2024

Originally the idea was to have the UI send these in. But adding it to the UI caused problems for other ARAs. So we hsould probably go ahead and add this in. Fugu if we can.

@cbizon
Copy link
Contributor Author

cbizon commented Jul 19, 2024

The issue with BTE has been solved, so perhaps the UI will pass the qual pred in. Take care of in guppy either way.

@cbizon cbizon added the guppy label Jul 19, 2024
@cbizon
Copy link
Contributor Author

cbizon commented Aug 30, 2024

Needs retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant