Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit Stop variants #41

Closed
ranweiler opened this issue Jun 22, 2021 · 0 comments · Fixed by #51
Closed

Revisit Stop variants #41

ranweiler opened this issue Jun 22, 2021 · 0 comments · Fixed by #51

Comments

@ranweiler
Copy link
Owner

The Stop variants are tuple structs. This can be nice for pattern matching, but is unhelpful when we are presenting two PIDs (e.g. in Stop::Exec.

Revisit this, and probably switch to variants with named fields. Explore whether there is value in adding a struct for the data associated with each stop type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use named fields for Stop variants with data ranweiler/pete
1 participant
@ranweiler