Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pronounciation and other finer control #35

Closed
Bikonja opened this issue Jan 7, 2023 · 10 comments
Closed

Pronounciation and other finer control #35

Bikonja opened this issue Jan 7, 2023 · 10 comments

Comments

@Bikonja
Copy link

Bikonja commented Jan 7, 2023

Hi,
would it be possible to extend this to support defining pronounciations for specific words? I see Edge has a few different options in the XML and there is a step here that converts the passed in message to XML before sending of to Edge TTS so perhaps exposing another function to pass in the direct XML instead for "advanced" users might be an easy way to extend support for things that aren't implemented as nice, easy options?

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

This function previously existed but was removed. It doesn't work properly due to Microsoft closing up the API and so I removed it. If you send XML that uses features not present in Edge browser the API will error out now.

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

It expects XML documents with only XML document formats that would be generated by Edge Browser. I believe it checks if it matches the template the browser uses.

@Bikonja
Copy link
Author

Bikonja commented Jan 7, 2023

Ah, thanks for the info.
If the API errors out, can you gracefully handle the error so it's a "might not work if you try it, but it's there if you want to try it"? Or was the problem that you kept getting issues opened for things that Edge didn't support and you didn't want to support that?

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

Well the issue was that the API didn't error out exactly, it just returned nothing. In any case it does raise an exception for when the API returns no audio.

Either way users of other libraries that depended on edge-tts made issues because the library that they were using was using custom SSML and was not working, so I removed it entirely.

I was never able to get it to do anything useful anyway. It used to support all the Azure Cognitive Services features but not anymore. It doesn't even support setting a custom pitch value.

@Bikonja
Copy link
Author

Bikonja commented Jan 7, 2023

Ah... That kind of sucks.
Let me see on Monday if I can find the team responsible for the Edge and see if they are planning to make the API more stable and support those extra features. Hold your fingers crossed, but temper your expectations :)
And thank you!

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

The API is stable, it's just that using the paid Azure Cognitive Services features no longer works. At the start they don't do any sort of filtering.

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

It's intentional, basically!

@Bikonja
Copy link
Author

Bikonja commented Jan 7, 2023

Oh, so they didn't shut it down, just moved it to a paid tier? Ok, I guess that makes sense... To be fair, it's one of the best TTS's around and the basica functionality is free so guess we can be happy with that at least :)

@rany2
Copy link
Owner

rany2 commented Jan 7, 2023

Well it was always a paid service. Azure Cognitive Services is a paid service for TTS generation. Edge browser's online TTS is basically just Azure Cognitive Services with restrictions.

Anyway if pronunciation and other fine control is available functionality in Edge, then I could probably add it to the library. Otherwise I guess this issue needs to be closed.

@Bikonja
Copy link
Author

Bikonja commented Jan 7, 2023

Got it, so it's essentially not even supposed to be free, and we just shouldn't talk about it and be happy it works :)
Cool, thanks, closing the issue.

@Bikonja Bikonja closed this as completed Jan 7, 2023
@Bikonja Bikonja closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants