Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rio cannot open files in the "folder" format. #107

Closed
moeyua opened this issue Jun 26, 2023 · 8 comments · Fixed by #461
Closed

Rio cannot open files in the "folder" format. #107

moeyua opened this issue Jun 26, 2023 · 8 comments · Fixed by #461
Labels
bug Something isn't working macos wishlist Features wishlist
Milestone

Comments

@moeyua
Copy link

moeyua commented Jun 26, 2023

Visual Studio Code external terminal support
image
image

@raphamorim raphamorim added the bug Something isn't working label Jun 26, 2023
@raphamorim
Copy link
Owner

Hey there @moeyua , thank you for the issue! Was that working before? (wonder if it has anything with the changes I've made for Microsoft Windows support)

@moeyua
Copy link
Author

moeyua commented Jun 26, 2023

Hey there @moeyua , thank you for the issue! Was that working before? (wonder if it has anything with the changes I've made for Microsoft Windows support)

This issue has been present since I started using Rio on June 6th.

@moeyua
Copy link
Author

moeyua commented Jun 26, 2023

Furthermore, I am using macOS Ventura 13.4, the latest versions of Visual Studio Code - Insiders and Visual Studio Code.

@raphamorim
Copy link
Owner

Ah ok, that's good to know. Will look on it 👌 thanks for all the details

@raphamorim raphamorim added this to the 0.0.8 milestone Jun 26, 2023
@raphamorim
Copy link
Owner

Figured out the reason.

Added the half of the support in fcb237f, it opens without alert but doesn't process the file path. The remaining part of the fix is to make Rio deal with the OpenFile events.

Will be looking on it for the next version (0.0.8)

References

@raphamorim raphamorim added macos wishlist Features wishlist labels Jun 26, 2023
@raphamorim raphamorim modified the milestones: 0.0.8, 0.0.9 Jul 3, 2023
@raphamorim
Copy link
Owner

@raphamorim raphamorim modified the milestones: 0.0.9, 0.1.0 Jul 12, 2023
@raphamorim raphamorim removed this from the 0.1.0 milestone Jul 19, 2023
@raphamorim raphamorim added this to the 0.0.19 milestone Sep 8, 2023
@nyabinary
Copy link

cc @raphamorim You need to move this to 0.0.21 milestone I'm pretty sure.

@raphamorim
Copy link
Owner

Implemented in #461

rio-demo-open-file

rio-demo-open-folder

Changes will be release along with 0.1.0 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macos wishlist Features wishlist
Projects
Development

Successfully merging a pull request may close this issue.

3 participants