Cleanup pSnuffle

[bcoles]

Before patch:

msf5 auxiliary(sniffer/psnuffle) > run
[-] Auxiliary failed: Msf::OptionValidateError The following options failed to validate: RHOSTS.

After patch:

msf5 auxiliary(sniffer/psnuffle) > run
[*] Auxiliary module running as background job 1.

[*] Loaded protocol FTP from /pentest/exploit/metasploit-framework/data/exploits/psnuffle/ftp.rb...
[*] Loaded protocol IMAP from /pentest/exploit/metasploit-framework/data/exploits/psnuffle/imap.rb...
[*] Loaded protocol POP3 from /pentest/exploit/metasploit-framework/data/exploits/psnuffle/pop3.rb...
[*] Loaded protocol SMB from /pentest/exploit/metasploit-framework/data/exploits/psnuffle/smb.rb...
[*] Loaded protocol URL from /pentest/exploit/metasploit-framework/data/exploits/psnuffle/url.rb...
[*] Sniffing traffic.....

Cleaned up some code while I was at it. Mostly removing tabs used for indentation, and removing string interpolation where it wasn't required.

[bcoles]

Since the addition of RHOSTS as a replacement for RHOST, the underlying issue could affect many modules which deregister RHOST. I haven't verified.

grep -rn deregister_options modules/auxiliary/ | grep RHOST | wc -l
102

[wvu]

Looks good. I miss the dsniff days.

[bcoles]

@wvu-r7 BetterCap in sniffing mode (-X --no-spoofing) is my modern goto for this purpose. I wrote a bunch of parsers for BetterCap (when it was written in Ruby). I'll look at porting these over to pSnuffle.

As for whether other modules are affected by this issue, the remainder are probably OK. Outside the scope of this PR - deal with it if/when it becomes an issue.

This PR is ready for merge.