Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pry and irb commands to developer dispatcher #10433

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Conversation

wvu
Copy link
Contributor

@wvu wvu commented Aug 8, 2018

We also fall back on prying Framework if a module isn't active.

This fixes the following bad behavior:

msf5 > pry
[*] exec: pry

And then your input gets stolen.

  • Test help and see pry listed
  • Test help pry and see pry help
  • Test pry in a module context
  • Test pry in any other context
msf5 > use exploit/linux/http/hp_van_sdn_cmd_inject
msf5 exploit(linux/http/hp_van_sdn_cmd_inject) > pry
[1] pry(#<Msf::Modules::Mod6578706c6f69742f6c696e75782f687474702f68705f76616e5f73646e5f636d645f696e6a656374::MetasploitModule>)>
msf5 exploit(linux/http/hp_van_sdn_cmd_inject) > back
msf5 > pry
[1] pry(#<Msf::Framework>)>

We also fall back on prying Framework if a module isn't active.

This fixes the following bad behavior:

msf5 > pry
[*] exec: pry

And then your input gets stolen.
@wvu wvu changed the title Move built-in pry command to developer dispatcher Move pry and irb commands to developer dispatcher Aug 8, 2018
@wvu wvu self-assigned this Aug 14, 2018
wvu added a commit to wvu/metasploit-framework that referenced this pull request Aug 14, 2018
@wvu wvu merged commit 89a3a26 into rapid7:master Aug 14, 2018
@wvu
Copy link
Contributor Author

wvu commented Aug 14, 2018

Release Notes

This moves the pry and irb commands in msfconsole into the developer command dispatcher, grouping all development-related commands together for better accessibility. This also fixes a misfeature where running pry outside a module context would hang. Now a Pry session is started in the Framework context.

@wvu wvu deleted the feature/pry branch August 14, 2018 18:42
@tdoan-r7 tdoan-r7 added the rn-enhancement release notes enhancement label Aug 29, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants