Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AUDIO_EFFECTS to distinguish from others #10744

Merged
merged 3 commits into from Oct 5, 2018
Merged

Add AUDIO_EFFECTS to distinguish from others #10744

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
566d540
Add AUDIO_EFFECTS to distinguish from others
wvu Oct 4, 2018
9e512b0
Clarify {SCREEN,AUDIO,PHYSICAL}_EFFECTS
wvu Oct 4, 2018
6efadb5
Further clarify {AUDIO,PHYSICAL}_EFFECTS
wvu Oct 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/msf/core/constants.rb
View file
Open in desktop
Expand Up @@ -82,7 +82,9 @@ module Msf
ACCOUNT_LOCKOUTS = 'account-lockouts'
# Module may show something on the screen (Example: a window pops up)
SCREEN_EFFECTS = 'screen-effects'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wchen-r7, @bcoles: Where do we want to draw the line with screen effects vs. visual effects vs. what is physical?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen being pop up boxes, relics displayed in a browser
Physical being cdrom ejection, scada valve movement
Visual being changing an external LED number display

That's how I'd think, but visual vs screen took a little bit of thinking about

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are we adding another constant?

Copy link
Contributor

@wchen-r7 wchen-r7 Oct 5, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for me that means:

SCREEN_EFFECTS: Something the user can see on the screen that allows them to realize the machine is being exploited.
PHYSICAL_EFFECTS: It involves a moving object.
AUDIO_EFFECTS: A noise or sound that allows the user to realize the machine is being exploited.
VISUAL_EFFECT: Kind of sounds like a sub-category of screen_effects. A little hard to draw the line for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add that physical could be a temperature as well. Like a Crock-Pot :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like sinn3r's summary of constants. I think these are solid (note: small edits):

# Module may show something on the screen (Example: a window pops up)
SCREEN_EFFECTS   = 'screen-effects'
# Module may cause a noise (Example: output audio from the speakers or hardware beep)
AUDIO_EFFECTS    = 'audio-effects'
# Module may produce physical effects (Example: the device moves)
PHYSICAL_EFFECTS = 'physical-effects'

The question remains whether an external LED or LCD falls within SCREEN_EFFECTS or a new VISUAL_EFFECTS category.

Copy link
Contributor Author

@wvu wvu Oct 5, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, hardware beeps should go in AUDIO_EFFECTS. We're trying to be specific and at the same time not confusing, heh.

I think I'll change "the device moves" to "the device makes movement," since the implication is that there is movement, not necessarily locomotion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h00die: I removed that because it potentially puts us in hot water. No pun intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've decided to leave VISUAL_EFFECTS out for now. It's a bit too nuanced to be useful right now, IMHO. I think we are in alignment with the current designations.

# Module may produce physical effects in hardware (Examples: light, sound, or heat)
# Module may cause a noise (Examples: audio output from the speakers or hardware beeps)
AUDIO_EFFECTS = 'audio-effects'
# Module may produce physical effects (Examples: the device makes movement or flashes LEDs)
PHYSICAL_EFFECTS = 'physical-effects'

#
Expand Down