-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start printjob docs and bug fixes #10981
Conversation
Jenkins test this please |
@h00die this diff should fix the RHOST setting issue:
The problem with delete in master is that it was not deleting aliases for a key if a key was deleted. This is important because by default 'RHOST' is an alias for 'RHOSTS' (setting or referring to either one always yields the same value). Because 'RHOSTS' was registered in the datastore originally in this module, the alias was set, but when the option was unregistered, the alias was not being removed. The 'find_key_case' function, when used in the Why RHOST assignment worked at all is a different story. I'm going to post a diff fixing this in a belt-and-suspenders way separately. |
@h00die the fix is in master now for |
Release NotesThis modernizes the printjob_capture auxiliary module and fixes up loot storage. |
Commit 063838f was overly aggresive about checking if an alias value exists in advance, which prevents aliases from being set altogether. da9e6ed was enought to fix the original issue reported in rapid7#10981 (comment)
Fixes to
printjob_capture
:rhosts
since I believe this was unintentionally added, and is similar to deregister_options RHOSTS #10660raise
withfail_with
nil
however it defaults to an empty string, thus making those branches in the code never reached. This means aRAW
print job never has its loot stored, nor is a document title ever assigned.I NEED HELP
Something strange is going on with
RHOST
. if you don't make it capital, it won't set. If you do, the datastore option still returnsnil
. This was not the case in Framework Version: 4.16.36-dev (what kali is currently running)Example:
Can someone at r7 take a look to see whats going on with
RHOST
?