Unregister aliases when a datastore option is unregistered #10998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #10981 (comment) if you unregister a datastore option with an alias, the alias would continue existing after the original option, causing it to continue receiving assignment values. The alias would continue overshadowing any directly-registered options as well.
This fixes 'delete' in the datastore class so it removes aliases for the deleted option. It also modifies find_key_case to require that an alias key actually exist before returning it (belt-and-suspenders), and observes that the linear scan of all keys was pointless in the non-alias case, since we fall through to returning the key anyway on no match.
Verification Steps