Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister aliases when a datastore option is unregistered #10998

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Unregister aliases when a datastore option is unregistered #10998

merged 3 commits into from
Nov 21, 2018

Commits on Nov 21, 2018

  1. delete option aliases when an option is deleted 

    Otherwise the aliases will remain active and if the aliased value is redefined
    @busterb
    busterb committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    da9e6ed View commit details
    Browse the repository at this point in the history

  2. ensure a value exists before returning the normalized key

    @busterb
    busterb committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    063838f View commit details
    Browse the repository at this point in the history

  3. Return the original key if it does not exist in the datastore

    @busterb
    busterb committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    7312fa7 View commit details
    Browse the repository at this point in the history