New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 in external probe scanner code #11002

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
3 participants
@acammack-r7
Contributor

acammack-r7 commented Nov 21, 2018

Removes a deprecated async declaration that was removed in 3.7. Minimum Python version to run the probe scanner code is now 3.5.3.

Verification

  • With Python 3.7
  • PYTHONPATH=$(pwd)/lib/msf/core/modules/external/python ./modules/auxiliary/scanner/wproxy/att_open_proxy.py --rhosts 127.0.0.1
  • Verify you get a "Connect failed" error and not a Python TypeError
@busterb

This comment has been minimized.

Contributor

busterb commented Nov 21, 2018

$ PYTHONPATH=$(pwd)/lib/msf/core/modules/external/python ./modules/auxiliary/scanner/wproxy/att_open_proxy.py --rhosts 127.0.0.1
[!] 127.0.0.1:49152 - Error connecting: [Errno 61] Connect call failed ('127.0.0.1', 49152)

Yep, good fix.

@busterb busterb merged commit 44da31e into rapid7:master Nov 21, 2018

2 of 3 checks passed

Metasploit Automation - Sanity Test Execution Build triggered for merge commit.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

busterb added a commit that referenced this pull request Nov 21, 2018

@busterb

This comment has been minimized.

Contributor

busterb commented Nov 21, 2018

Release Notes

This fix adds Python 3.7 support for external Python scanner modules and raises the minimum Python 3 version to 3.5.3.

msjenkins-r7 added a commit that referenced this pull request Nov 21, 2018

@gdavidson-r7 gdavidson-r7 added the rn-fix label Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment