Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.7 in external probe scanner code #11002

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

acammack-r7
Copy link
Contributor

@acammack-r7 acammack-r7 commented Nov 21, 2018

Removes a deprecated async declaration that was removed in 3.7. Minimum Python version to run the probe scanner code is now 3.5.3.

Verification

  • With Python 3.7
  • PYTHONPATH=$(pwd)/lib/msf/core/modules/external/python ./modules/auxiliary/scanner/wproxy/att_open_proxy.py --rhosts 127.0.0.1
  • Verify you get a "Connect failed" error and not a Python TypeError

@acammack-r7 acammack-r7 added bug external modules PRs dealing with modules run as their own process labels Nov 21, 2018
@busterb busterb self-assigned this Nov 21, 2018
@busterb
Copy link
Member

busterb commented Nov 21, 2018

$ PYTHONPATH=$(pwd)/lib/msf/core/modules/external/python ./modules/auxiliary/scanner/wproxy/att_open_proxy.py --rhosts 127.0.0.1
[!] 127.0.0.1:49152 - Error connecting: [Errno 61] Connect call failed ('127.0.0.1', 49152)

Yep, good fix.

@busterb busterb merged commit 44da31e into rapid7:master Nov 21, 2018
@busterb
Copy link
Member

busterb commented Nov 21, 2018

Release Notes

This fix adds Python 3.7 support for external Python scanner modules and raises the minimum Python 3 version to 3.5.3.

@gdavidson-r7 gdavidson-r7 added the rn-fix release notes fix label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external modules PRs dealing with modules run as their own process rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants