Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
update PR template to ask for unique branch #11200
I like the idea, given the number of PRs we've had to kill due to merging from
It might be best to reference a URL, that we control and can update, rather than my template comment reply (which I stole from someone @ r7).
I took a look through the existing msf documentation and couldn't find any relevant references.
The CONTRIBUTING.md states:
The other references for contributors on the wiki aren't helpful either.
Following that link takes you to a page which begins by stating in bold
someone-who-isn't-me should probably write up some simple steps somewhere for newbies to create a topic branch. Here's some steps for someone to copypasta somewhere:
I think the link to https://github.com/rapid7/metasploit-framework/wiki/Landing-Pull-Requests really ought to point to something like this: https://gist.github.com/Chaser324/ce0505fbed06b947d962