Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auxiliary/scanner/http/dir_listing documentation #11384

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Adding auxiliary/scanner/http/dir_listing documentation #11384

merged 2 commits into from
Feb 14, 2019

Conversation

Yashvendra
Copy link
Contributor

This PR adds the documentation for auxiliary/scanner/http/dir_listing

@h00die
Copy link
Contributor

h00die commented Feb 11, 2019

would it be possible to add in some 'how to make this vulnerable' type instructions? nginx and apache would be awesome, but not super pressed about it. See https://github.com/rapid7/metasploit-framework/blob/master/documentation/modules/auxiliary/gather/ipcamera_password_disclosure.md#setup while that is different, its awesome to have some instructions for making the target vulnerable to test the module.

@h00die h00die added the docs label Feb 11, 2019
@h00die
Copy link
Contributor

h00die commented Feb 11, 2019

I believe you also set verbose to true since it printed the NOT vulnerable part, but i dont see that in the instructions

@Yashvendra
Copy link
Contributor Author

would it be possible to add in some 'how to make this vulnerable' type instructions? nginx and apache would be awesome, but not super pressed about it. See https://github.com/rapid7/metasploit-framework/blob/master/documentation/modules/auxiliary/gather/ipcamera_password_disclosure.md#setup while that is different, its awesome to have some instructions for making the target vulnerable to test the module.

Yes it would be awesome, will surely look into it.

@Yashvendra
Copy link
Contributor Author

I believe you also set verbose to true since it printed the NOT vulnerable part, but i dont see that in the instructions

Yeah, didn't mention the verbose part. Should I add it or remove the NOT part ?

@h00die
Copy link
Contributor

h00die commented Feb 11, 2019

I would just add the 2 lines showing you marked verbose (set verbose true, verbose => true). that's easier than removing all the non-vuln hosts, plus it shows what to expect in that use case which is a bonus

@h00die h00die self-assigned this Feb 11, 2019
@h00die h00die self-requested a review February 11, 2019 15:41
@Yashvendra
Copy link
Contributor Author

I would just add the 2 lines showing you marked verbose (set verbose true, verbose => true). that's easier than removing all the non-vuln hosts, plus it shows what to expect in that use case which is a bonus

Surely will do it. And about the 'how to make this vulnerable' part, can I simply create a php file enabling the directory listing and run it on the server then test it or should I use nginx and apache. What do you suggest?

@h00die
Copy link
Contributor

h00die commented Feb 11, 2019

Whatever makes it vulnerable works for me!

@bcoles
Copy link
Contributor

bcoles commented Feb 12, 2019

can I simply create a php file enabling the directory listing

Whatever works; however a .htaccess file with Indexes is more traditional.

@Yashvendra
Copy link
Contributor Author

Done.

@h00die h00die merged commit f731acc into rapid7:master Feb 14, 2019
h00die added a commit that referenced this pull request Feb 14, 2019
msjenkins-r7 pushed a commit that referenced this pull request Feb 14, 2019
@h00die
Copy link
Contributor

h00die commented Feb 14, 2019

I did a slight cleanup, so minor i didn't want to hold up the rest of this by pushing back again.
Typically we sanitize IPs to 1) not give away your network architecture, 2) save space (192.168.1. is 4 characters larger than 1.1.1., and that space adds up over a few hundred or thousand modules). I also summarized your .htaccess file generation down to one line.
Nice docs, thanks for the contribution!!!!!

53e5f88

@h00die
Copy link
Contributor

h00die commented Feb 14, 2019

Release Notes

Documentation has been added for the auxiliary/scanner/http/dir_listing module.

@h00die h00die added this to the Module documentation milestone Feb 14, 2019
@Yashvendra Yashvendra deleted the patch-1 branch February 14, 2019 02:25
@Yashvendra
Copy link
Contributor Author

I did a slight cleanup, so minor i didn't want to hold up the rest of this by pushing back again.
Typically we sanitize IPs to 1) not give away your network architecture, 2) save space (192.168.1. is 4 characters larger than 1.1.1., and that space adds up over a few hundred or thousand modules). I also summarized your .htaccess file generation down to one line.
Nice docs, thanks for the contribution!!!!!

53e5f88

Thanks @h00die I'll keep this in mind for the next time.

@gdavidson-r7 gdavidson-r7 added the rn-enhancement release notes enhancement label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants