Update module stance instead of appending to it #11734
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redux of the fixes #9387 and #9822.
While this is the correct solution, I think it's okay to keep the other code for safety.
Note that either the module or one of its mixins will need to set the appropriate stance. This fix simply makes stance a binary, so inheritance and mixin order are especially important now.
Please note that the default behavior of
update_info
is to convert to an array and append to it.metasploit-framework/lib/msf/core/module/module_info.rb
Lines 90 to 95 in 93638b7
#11711