correct output printing bug from scanner/smb/smb_enumshares #12140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release NotesThe output from scanner/smb/smb_enumshares now displays correctly. |
wchen-r7
added a commit
that referenced
this pull request
Jul 29, 2019
msjenkins-r7
pushed a commit
that referenced
this pull request
Jul 29, 2019
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch remove a call to Text.to_ascii which removed half the letters in the share types
the Text.to_ascii remove half the letters from the sharetype array because it treats it like utf16
when in reality it is a local array
it can be seen in scanner/smb/smb_enumshares :
before patch :
`msf5 auxiliary(scanner/smb/smb_enumshares) > run
[-] 192.168.56.101:139 - Login Failed: Unable to Negotiate with remote host
[+] 192.168.56.101:445 - ADMIN$ - (DS) Remote Admin
[+] 192.168.56.101:445 - C$ - (DS) Default share
[+] 192.168.56.101:445 - IPC$ - (I) Remote IPC
[*] 192.168.56.101: - Scanned 1 of 1 hosts (100% complete)
`
after patch :
`msf5 auxiliary(scanner/smb/smb_enumshares) > run
[-] 192.168.56.101:139 - Login Failed: Unable to Negotiate with remote host
[+] 192.168.56.101:445 - ADMIN$ - (DISK) Remote Admin
[+] 192.168.56.101:445 - C$ - (DISK) Default share
[+] 192.168.56.101:445 - IPC$ - (IPC) Remote IPC
[*] 192.168.56.101: - Scanned 1 of 1 hosts (100% complete)
`