Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct output printing bug from scanner/smb/smb_enumshares #12140

Merged
merged 1 commit into from Jul 29, 2019

Conversation

@nounesh
Copy link

commented Jul 28, 2019

This patch remove a call to Text.to_ascii which removed half the letters in the share types

the Text.to_ascii remove half the letters from the sharetype array because it treats it like utf16
when in reality it is a local array
it can be seen in scanner/smb/smb_enumshares :

before patch :

`msf5 auxiliary(scanner/smb/smb_enumshares) > run

[-] 192.168.56.101:139 - Login Failed: Unable to Negotiate with remote host
[+] 192.168.56.101:445 - ADMIN$ - (DS) Remote Admin
[+] 192.168.56.101:445 - C$ - (DS) Default share
[+] 192.168.56.101:445 - IPC$ - (I) Remote IPC
[*] 192.168.56.101: - Scanned 1 of 1 hosts (100% complete)
`

after patch :
`msf5 auxiliary(scanner/smb/smb_enumshares) > run

[-] 192.168.56.101:139 - Login Failed: Unable to Negotiate with remote host
[+] 192.168.56.101:445 - ADMIN$ - (DISK) Remote Admin
[+] 192.168.56.101:445 - C$ - (DISK) Default share
[+] 192.168.56.101:445 - IPC$ - (IPC) Remote IPC
[*] 192.168.56.101: - Scanned 1 of 1 hosts (100% complete)
`

@wchen-r7 wchen-r7 merged commit 4856e0f into rapid7:master Jul 29, 2019

3 checks passed

Metasploit Automation - Sanity Test Execution Successfully completed all tests.
Details
Metasploit Automation - Test Execution Successfully completed all tests.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wchen-r7

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

Release Notes

The output from scanner/smb/smb_enumshares now displays correctly.

wchen-r7 added a commit that referenced this pull request Jul 29, 2019

msjenkins-r7 added a commit that referenced this pull request Jul 29, 2019

@tdoan-r7 tdoan-r7 added the rn-fix label Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.