Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified smtp_enum using the patch given in RedMine Bug #7278 #1259

Conversation

lmercer-r7
Copy link

No description provided.

@@ -1,5 +1,4 @@
##
# $Id$
d: smtp_enum.rb 14774 2012-02-21 01:42:17Z rapid7 $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a failed attempt to remove $Id$ tag?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! You're right, I screwed that guy up.

@jlee-r7
Copy link
Contributor

jlee-r7 commented Jan 7, 2013

@todb-r7
Copy link

todb-r7 commented Jan 8, 2013

Note that given the occasional total whitespace shift and recent drop of SVN keywords, it's unlikely any patch posted to Redmine is going to apply cleanly the first time.

]
)], self.class)
]),
OptBool.new('UNIXONLY', [ true, 'Skip Microsoft bannered servers when testing unix users', true])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could make this description shorter......."Skip IIS SMTP banners" ??

@todb-r7
Copy link

todb-r7 commented Mar 18, 2013

The lack of interest from the original author (Thomas Ring) and the extremely out of date patch pulled from an older SVN revision makes this extremely difficult to land. If Thomas surfaces again, I'd love to see what these fixes are actually intending to do. In the meantime, closing due to merge conflicts.

@todb-r7 todb-r7 closed this Mar 18, 2013
@wvu wvu mentioned this pull request Jun 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants