Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alternative smtp_enum.rb #1915

Merged
merged 2 commits into from Jun 7, 2013
Merged

alternative smtp_enum.rb #1915

merged 2 commits into from Jun 7, 2013

Conversation

nowhey2
Copy link
Contributor

@nowhey2 nowhey2 commented Jun 6, 2013

http://dev.metasploit.com/redmine/issues/7278#change-35839

Not sure why Todd thought I was gone...module still works just fine...pull request submitted to make it easier...

…tives, false negatives, stack traces, enumering unix users on windows systems, etc)
@@ -1,4 +1,8 @@
##
# $Id: smtp_enum.rb 14774 2012-02-21 01:42:17Z rapid7 $
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$Id$ was for Subversion. It is no longer needed or expanded in git. This entire comment block can be removed.

@nowhey2
Copy link
Contributor Author

nowhey2 commented Jun 6, 2013

So do I make the changes and re-commit or is this something you guys do, not had so many markups before :) ?

else
print_good("#{target} E-mail addresses found: #{@mails_found.keys.sort.join(", ")}")
def finish_host(users_found)
ip, port = target.split(':')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target is the concatenation of rhost and rport. Use them instead of pulling them back out of target.

@wvu
Copy link
Contributor

wvu commented Jun 6, 2013

The original pull request is #1259.

@nowhey2
Copy link
Contributor Author

nowhey2 commented Jun 6, 2013

requested changes made with new commit

@todb
Copy link
Contributor

todb commented Jun 6, 2013

ah ha, thanks for taking this module back up, @ringt !

jlee-r7 pushed a commit that referenced this pull request Jun 7, 2013
@jlee-r7 jlee-r7 merged commit 8cf5b54 into rapid7:master Jun 7, 2013
@wvu
Copy link
Contributor

wvu commented Jun 7, 2013

Hey, @ringt. Great job!

@nowhey2
Copy link
Contributor Author

nowhey2 commented Jun 7, 2013

Ty, my pleasure
------Original Message------
From: wvu-r7
To: rapid7/metasploit-framework
Cc: ringt
ReplyTo: rapid7/metasploit-framework
Subject: Re: [metasploit-framework] alternative smtp_enum.rb (#1915)
Sent: Jun 7, 2013 12:30 PM

Hey, @ringt https://github.com/ringt . Great job!

Reply to this email directly or view it on GitHub.
Sent via BlackBerry by AT&T

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants