New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alternative smtp_enum.rb #1915
alternative smtp_enum.rb #1915
Conversation
…tives, false negatives, stack traces, enumering unix users on windows systems, etc)
@@ -1,4 +1,8 @@ | |||
## | |||
# $Id: smtp_enum.rb 14774 2012-02-21 01:42:17Z rapid7 $ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$Id$
was for Subversion. It is no longer needed or expanded in git. This entire comment block can be removed.
So do I make the changes and re-commit or is this something you guys do, not had so many markups before :) ? |
else | ||
print_good("#{target} E-mail addresses found: #{@mails_found.keys.sort.join(", ")}") | ||
def finish_host(users_found) | ||
ip, port = target.split(':') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target
is the concatenation of rhost
and rport
. Use them instead of pulling them back out of target
.
The original pull request is #1259. |
requested changes made with new commit |
ah ha, thanks for taking this module back up, @ringt ! |
Hey, @ringt. Great job! |
Ty, my pleasure Hey, @ringt https://github.com/ringt . Great job! |
http://dev.metasploit.com/redmine/issues/7278#change-35839
Not sure why Todd thought I was gone...module still works just fine...pull request submitted to make it easier...