Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove inappropriate python files from issue_finder #13176

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Mar 31, 2020

#12389 (comment)

@tekwizz123 noticed a bug in the issue_finder.py code where _msf_impacket.py and _msf_impacket.pyc were being listed as needing docs. Obvi they don't, so this patch will remove all .pyc and files that contain with an underscore /_.

@agalway-r7 agalway-r7 self-assigned this Mar 31, 2020
@agalway-r7 agalway-r7 merged commit 556af54 into rapid7:master Mar 31, 2020
@agalway-r7 agalway-r7 added the rn-fix release notes fix label Mar 31, 2020
@agalway-r7
Copy link
Contributor

agalway-r7 commented Mar 31, 2020

Release Notes

The issue_finder.py used for finding modules without documentation, no longer lists .pyc files or files beginning with _.

@h00die h00die deleted the double_impacket branch March 31, 2020 13:08
@hkerma
Copy link
Contributor

hkerma commented Oct 6, 2020

Hi, thanks a lot for correcting this issue !
I didn't think about .pyc extension at first ...

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docs rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants