-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enum_xchat updates and upgrades #13306
Conversation
OptBool.new('HEXCHAT', [false, 'Enumerate hexchat', true ]), | ||
OptBool.new('XCHAT', [false, 'Enumerate xchat', false ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason not to do both by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured since it hasn't been maintained in 5yrs, it's unlikely anyone is running it. We could save a few system calls by not looking for it by default
Does anyone even still use XChat? |
|
No one using BitchX? ;)) |
I tried, but I was too lame to read bitchx.doc |
Turns out the windows and linux code for chat logs on xchat is the same. So i've just removed that code. |
|
Release NotesThe |
enum_xchat
hasn't been updated in almost 8yrs (#291). This update does several things to help get it inline for #11998:rubocop -a
Verification
I wasn't able to get xchat installed on fedora 31, too many libs that have to be OLD or manually compiled. Didn't seem worth the time. Since I wasn't able to install, I left sinn3r's original code there for enumerating log files. The regex seemed overly complex, so I didn't want to change it w/o knowing what it did and having some test data.