Dyn dns update fix

[digininja]

The resolve function used to always return true, regardless whether the record it was asked to resolve existed or not, this broke some onward calls when they tried to update things that didn't really exist.

Verification

List the steps needed to make sure this thing works

• Try to update a record that doesn't exist:

msf6 auxiliary(admin/dns/dyn_dns_update) > set ACTION UPDATE
ACTION => UPDATE
msf6 auxiliary(admin/dns/dyn_dns_update) > set HOSTNAME new2
HOSTNAME => new2
msf6 auxiliary(admin/dns/dyn_dns_update) > run

[+] Did not find an existing TXT record for new2.digi.int
[*] Sending dynamic DNS add message...
[+] The record 'new2.digi.int => aa' has been added!
[*] Auxiliary module execution completed

It gets added

• Now run it again and it will get updated

msf6 auxiliary(admin/dns/dyn_dns_update) > run

[+] Found existing TXT record for new2.digi.int
[*] Sending dynamic DNS delete message...
[+] The record 'new2.digi.int => aa' has been deleted!
[*] Sending dynamic DNS add message...
[+] The record 'new2.digi.int => aa' has been added!
[*] Auxiliary module execution completed
msf6 auxiliary(admin/dns/dyn_dns_update) > 

[cnotin]

Psst looks like the branch also contains the commit of #13957 ;)

[digininja]

Ye, I needed that fix to do this one.

Do I remove that and resubmit? I don't know the correct way to do these.

[digininja]

I've removed the lines from the other PR

[cnotin]

That's one way to do it. Or you could have amended your commit and force pushed your PR branch. Github handles it fine and as long as no one has started to look into it it shouldn't bother.

[digininja]

I used your suggestion of editing in the browser. It just worked!

…

On Fri, 7 Aug 2020, 13:01 Clément Notin, ***@***.***> wrote: That's one way to do it. Or you could have amended your commit and force pushed your PR branch. Github handles it fine and as long as no one has started to look into it it shouldn't bother. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13958 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4SWJQPOATA62WVNT3QMDR7PUH7ANCNFSM4PXRHUEQ> .

[cnotin]

Yes if you want to add a commit to an existing PR you can indeed edit the file in your fork and in the branch 😉

[smcintyre-r7]

Well it looks like it would return false if a Dnsruby::ResolveError exception was raised, however these changes are still beneficial because they'll account for scenarios in which there's a response with no answers. I tested this against both my BIND and Microsoft DNS servers and that doesn't seem to be the case with either but it sounds reasonable enough that other DNS server implementations may exhibit this behavior.

I did confirm that the module functions as intended both before and after this update so I'm ready to merge it in thanks!

[smcintyre-r7]

Release Notes

Updated the auxiliary/admin/dns/dyn_dns_update module to properly identify that a record is missing when a valid DNS response is returned with no answers.

[digininja]

Great, thanks.

…

On Fri, 7 Aug 2020, 17:49 Spencer McIntyre, ***@***.***> wrote: Merged #13958 <#13958> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13958 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA4SWMYHKF4ZBQGDJ2KOOTR7QWBJANCNFSM4PXRHUEQ> .