-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dyn dns update fix #13958
Dyn dns update fix #13958
Conversation
Psst looks like the branch also contains the commit of #13957 ;) |
Ye, I needed that fix to do this one. Do I remove that and resubmit? I don't know the correct way to do these. |
removed commit from other PR
I've removed the lines from the other PR |
That's one way to do it. Or you could have amended your commit and force pushed your PR branch. Github handles it fine and as long as no one has started to look into it it shouldn't bother. |
I used your suggestion of editing in the browser. It just worked!
…On Fri, 7 Aug 2020, 13:01 Clément Notin, ***@***.***> wrote:
That's one way to do it. Or you could have amended your commit and force
pushed your PR branch. Github handles it fine and as long as no one has
started to look into it it shouldn't bother.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13958 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWJQPOATA62WVNT3QMDR7PUH7ANCNFSM4PXRHUEQ>
.
|
Yes if you want to add a commit to an existing PR you can indeed edit the file in your fork and in the branch 😉 |
Well it looks like it would return I did confirm that the module functions as intended both before and after this update so I'm ready to merge it in thanks! |
Release NotesUpdated the |
Great, thanks.
…On Fri, 7 Aug 2020, 17:49 Spencer McIntyre, ***@***.***> wrote:
Merged #13958 <#13958>
into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13958 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWMYHKF4ZBQGDJ2KOOTR7QWBJANCNFSM4PXRHUEQ>
.
|
The resolve function used to always return true, regardless whether the record it was asked to resolve existed or not, this broke some onward calls when they tried to update things that didn't really exist.
Verification
List the steps needed to make sure this thing works
It gets added