-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow dns server on different port #13957
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
adfoster-r7
reviewed
Aug 7, 2020
Removed the deregistering of RPORT
smcintyre-r7
approved these changes
Aug 7, 2020
Tested this and it's working as intended. Changed my BIND server to run on port 5353 and ran through the test case. Testing Output
I'll have this merged in momentarily, thanks @digininja ! |
Release NotesUpdated the |
Thanks.
…On Fri, 7 Aug 2020 at 21:17, Spencer McIntyre ***@***.***> wrote:
Release Notes
This updates the auxiliary/admin/dns/dyn_dns_update module to allow the
remote port to be specified. This makes it able to target servers that run
on non-standard ports.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13957 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWL43EPBFNNNVU35SHLR7ROMHANCNFSM4PXQKQ6A>
.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what this change does. If you're fixing a bug, please mention
the github issue number.
Please ensure you are submitting from a unique branch in your repository to master in Rapid7's.
Verification
List the steps needed to make sure this thing works
Start a DNS server on a non-standard port - I'm on 5353
msfconsole
use auxiliary/admin/dns/dyn_dns_update
set RPORT 5353
The one thing I can't get it to do is to show the RPORT in the list of options. I've copied code that works from other modules but it won't show up.