Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix for error logged in import #14538

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

jmartin-tech
Copy link
Contributor

@jmartin-tech jmartin-tech commented Dec 21, 2020

print_error is not commonly used in import classes, this may not
be the best solution, however the message format needs to be addressed.

Verification

List the steps needed to make sure this thing works

  • run rake spec
  • Verify logged messages for failed decode

`print_error` is not commonly used in import classes, this may not
be the best solution, however the typo needs to be addressed.
@gwillcox-r7 gwillcox-r7 self-assigned this Dec 21, 2020
@gwillcox-r7
Copy link
Contributor

gwillcox-r7 commented Dec 21, 2020

Looks to be working as expected:

*cut for brevity*
Msf::DBImportError .
Msf::DBManager ........................................................................................................................................................................................................................................[-] Data format suggests response body is not encoded: invalid base64
...........................................[-] Data format suggests response body is not encoded: invalid base64
.....[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
.[-] Data format suggests response body is not encoded: invalid base64
..................................................................................................................................................................................................................................................
Metasploit::Framework::LoginScanner::Tomcat ..................................................
*cut for bevity*
Finished in 4 minutes 47.3 seconds (files took 6.18 seconds to load)
11691 examples, 0 failures, 33 pending

Randomized with seed 21755
Coverage report generated for RSpec to /home/gwillcox/git/metasploit-framework/coverage. 62941 / 110345 LOC (57.04%) covered.
 ~/git/metasploit-framework │ land-pr14538:pr/14538 !1 ?14   

@gwillcox-r7 gwillcox-r7 merged commit b717278 into rapid7:master Dec 21, 2020
@gwillcox-r7 gwillcox-r7 added enhancement rn-enhancement release notes enhancement labels Dec 21, 2020
@gwillcox-r7
Copy link
Contributor

gwillcox-r7 commented Dec 21, 2020

Release Notes

Improved Metasploit's XML importer to throw a more descriptive error message when importing data whose response body is not appropriately Base64 encoded.

@jmartin-tech jmartin-tech deleted the add-error-space branch August 27, 2024 15:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants