-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds some testing for Rex HTTP client lib #1478
Conversation
In light ofi PR #1476, it would be nice to have some basic, modern, maintained testing on Rex's HTTP Client proto library. My rspec fu is quite weak, of course, but this should cover the very basic cases. There are lots of pending holes, but hey, it's a start.
Hey @limhoff-r7 or @jlee-r7 how do I get these tests in the regular |
Only files matching spec/*_/__spec.rb will be picked up. You named the file wrong. |
Wow, even I knew that ;) |
<-- noob. Thank you @limhoff-r7 ! :) |
That's a bad habit to get into.
You could add it 'should do something', :pending => 'reason' do
end Is the generic syntax. |
|
||
cli = Rex::Proto::Http::Client.new(ip) | ||
it "should respond to intialize" do | ||
cli.should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dude. That's deep, man.
See todb-r7#1 |
Thanks @jlee-r7 my notificatiosn for my own PRs are all screwed up ATM, so didn't see this (or any other comments on my PRs, boo) |
Reading through @limhoff-r7 's varied pearls of wisdom, too, will implement for sure. |
In light of PR #1476, it would be nice to have some basic,
maintained testing on Rex's HTTP Client proto library.
My rspec fu is quite weak, of course, but this should cover the very
basic cases. There are lots of pending holes, but hey, it's a start.