Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some testing for Rex HTTP client lib #1478

Merged
merged 8 commits into from
Feb 25, 2013
Merged

Adds some testing for Rex HTTP client lib #1478

merged 8 commits into from
Feb 25, 2013

Conversation

todb-r7
Copy link

@todb-r7 todb-r7 commented Feb 11, 2013

In light of PR #1476, it would be nice to have some basic,
maintained testing on Rex's HTTP Client proto library.

My rspec fu is quite weak, of course, but this should cover the very
basic cases. There are lots of pending holes, but hey, it's a start.

In light ofi PR #1476, it would be nice to have some basic, modern,
maintained testing on Rex's HTTP Client proto library.

My rspec fu is quite weak, of course, but this should cover the very
basic cases. There are lots of pending holes, but hey, it's a start.
@todb-r7
Copy link
Author

todb-r7 commented Feb 11, 2013

Hey @limhoff-r7 or @jlee-r7 how do I get these tests in the regular rake spec run? They're not getting picked up and I'm not sure why.

@limhoff-r7
Copy link
Contributor

Only files matching spec/*_/__spec.rb will be picked up. You named the file wrong.

@todb-r7 todb-r7 mentioned this pull request Feb 12, 2013
@kernelsmith
Copy link
Contributor

Wow, even I knew that ;)

@todb-r7
Copy link
Author

todb-r7 commented Feb 12, 2013

<-- noob. Thank you @limhoff-r7 ! :)

@todb-r7
Copy link
Author

todb-r7 commented Feb 13, 2013

This needs to be updated now that #1444 and #1476 have been backed out, since now some methods are missing.

@limhoff-r7
Copy link
Contributor

You could add :pending => '<link to PR>' to mark the examples as pending until the new PRs for 1444 and 1476 land. Or just a string saying 'Waiting for #1444 and #1476 to be remerged', but that's more opaque. Then, as part of the new PRs for that, they would remove the :pending tag, as a pending example that passes, counts as a failure since they should no longer be pending.

it 'should do something', :pending => 'reason' do
end 

Is the generic syntax.


cli = Rex::Proto::Http::Client.new(ip)
it "should respond to intialize" do
cli.should be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude. That's deep, man.

@jlee-r7
Copy link
Contributor

jlee-r7 commented Feb 20, 2013

See todb-r7#1

@todb-r7
Copy link
Author

todb-r7 commented Feb 25, 2013

Thanks @jlee-r7 my notificatiosn for my own PRs are all screwed up ATM, so didn't see this (or any other comments on my PRs, boo)

@todb-r7
Copy link
Author

todb-r7 commented Feb 25, 2013

Reading through @limhoff-r7 's varied pearls of wisdom, too, will implement for sure.

@todb-r7 todb-r7 merged commit 7738bf8 into rapid7:master Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants