Fix #14888, fix downloading a utf-8 directory directly

[timwr]

This change fixes a similar bug to #14888 , but this time you need to specify the directory directly
This change ensure the directory source and destination are UTF-8 encoded.

Verification

List the steps needed to make sure this thing works

• Start msfconsole
• Get any meterpreter session (I was able to reproduce on both Android and linux/x64 (mettle))
• Ensure you have a database connected
• Verify the following:

meterpreter > mkdir testunicode
Creating directory: testunicode
meterpreter > cd testunicode
meterpreter > mkdir 🔥
Creating directory: 🔥
meterpreter > cd 🔥
meterpreter > edit ⚡
meterpreter > ls
Listing: /metasploit-framework/testunicode/🔥
==============================================================

Mode              Size  Type  Last modified              Name
----              ----  ----  -------------              ----
100664/rw-rw-r--  0     fil   2021-03-13 11:13:19 +0000  ⚡

meterpreter > cd ..
meterpreter > download 🔥
[*] mirroring  : ./🔥 -> /metasploit-framework/🔥
[*] downloading: ./🔥/⚡ -> /metasploit-framework/🔥/⚡
[*] download   : ./🔥/⚡ -> /metasploit-framework/🔥/⚡
[*] mirrored   : ./🔥 -> /metasploit-framework/🔥
meterpreter > exit

Before the fix:

meterpreter > mkdir testunicode
Creating directory: testunicode
meterpreter > cd testunicode
meterpreter > mkdir 🔥
Creating directory: 🔥
meterpreter > cd 🔥
meterpreter > edit ⚡
meterpreter > cd ..
meterpreter > download 🔥
[-] Error running command download: Encoding::CompatibilityError incompatible character encodings: ASCII-8BIT and UTF-8

[gwillcox-r7]

Fix confirmed to be working, nice work @timwr, going to land this now.

[gwillcox-r7]

Release Notes

Fixed a bug in the download command in Meterpreter, where attempts to download a directory containing UTF-8 characters would result in an error. This has been resolved by enforcing the correct encoding.