Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in Eclipse Equinox product name #15088

Conversation

erran
Copy link
Contributor

@erran erran commented Apr 23, 2021

The module docs had an extra character for the product name that makes
copy-paste search less straight forward.

Verification

  • Read the fixed module docs
  • The module metadata generation should catch this typo fix

Fixes #9554.

The osgi_console_exec module docs had a few stray characters for the
product name and description. The product name confused me when
googling for this module.
@erran erran force-pushed the erran/docs/fix-typo-in-eclipse-equinox-product-name branch from c58280e to dcf457f Compare April 23, 2021 10:58
@adfoster-r7
Copy link
Contributor

@msjenkins-r7 retest this please

@gwillcox-r7
Copy link
Contributor

@msjenkins-r7 retest this please

@gwillcox-r7 gwillcox-r7 self-assigned this Apr 23, 2021
@jmartin-tech
Copy link
Contributor

@msjenkins-r7 test this please.

@adfoster-r7
Copy link
Contributor

@gwillcox-r7 Looks like this should be good to merge now 👍

@gwillcox-r7
Copy link
Contributor

Thanks, merging now that this has passed all checks....

@gwillcox-r7 gwillcox-r7 merged commit 6b4e5a7 into rapid7:master Apr 23, 2021
@gwillcox-r7 gwillcox-r7 added the rn-no-release-notes no release notes label Apr 23, 2021
@erran erran deleted the erran/docs/fix-typo-in-eclipse-equinox-product-name branch April 24, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants