Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/gather/enum_domains: Return early if no domains are found #16109

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

bcoles
Copy link
Contributor

@bcoles bcoles commented Jan 28, 2022

Fixes #15541.

Before:

msf6 post(windows/gather/enum_domains) > rexploit 
[*] Reloading module...

[-] ERROR_NO_BROWSER_SERVERS_FOUND
[-] Post failed: NoMethodError undefined method `each' for nil:NilClass
[-] Call stack:
[-]   /root/Desktop/metasploit-framework/modules/post/windows/gather/enum_domains.rb:27:in `run'
[*] Post module execution completed

After:

msf6 post(windows/gather/enum_domains) > rexploit 
[*] Reloading module...

[-] ERROR_NO_BROWSER_SERVERS_FOUND
[*] Post module execution completed

@bcoles bcoles force-pushed the post-windows-gather-enum-domains branch from a35a4bf to 04552d7 Compare January 28, 2022 11:07
@3V3RYONE
Copy link
Contributor

May I start by reviewing this PR? :)

@bcoles
Copy link
Contributor Author

bcoles commented Jan 28, 2022

May I start by reviewing this PR? :)

You can if you like, but it fixes an issue reported by @adfoster-r7 and would require his input.

It also changes only a single line. The reasoning behind the change is described in #15541 (comment).

@3V3RYONE
Copy link
Contributor

May I start by reviewing this PR? :)

You can if you like, but it fixes an issue reported by @adfoster-r7 and would require his input.

It also changes only a single line. The reasoning behind the change is described in #15541 (comment).

Yes! I checked that.. In that case, let adfoster-r7 review! I'll pick up another one! :)

@adfoster-r7 adfoster-r7 merged commit c3647aa into rapid7:master Jan 28, 2022
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Jan 28, 2022

Release Notes

Fixes a crash in post/windows/gather/enum_domains when no domains are found

@adfoster-r7
Copy link
Contributor

Thanks! 🎉

@bcoles bcoles deleted the post-windows-gather-enum-domains branch January 29, 2022 04:01
@gwillcox-r7
Copy link
Contributor

Adding in missing release note tags.

@gwillcox-r7 gwillcox-r7 added the rn-fix release notes fix label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug module rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

post/windows/gather/enum_domains crashes
4 participants