Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zimbra_slapper_priv_esc.rb #17825

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Update zimbra_slapper_priv_esc.rb #17825

merged 1 commit into from
Mar 28, 2023

Conversation

dm-ct
Copy link
Contributor

@dm-ct dm-ct commented Mar 27, 2023

fixing reference to use an archive.org link as the site referenced is down and probably won't be coming back up anytime soon.

as an aside, I might do this for other modules with dead reference links. Is there a preferred way to do this? Or just ad-hoc PR's?

fixing reference to use an archive link as the sites down.
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Mar 27, 2023

Thanks for the PR; Will be able to land once CI is green 👍

as an aside, I might do this for other modules with dead reference links. Is there a preferred way to do this? Or just ad-hoc PR's?

I ran into something similar with broken Secunia references and put up a similar PR over here: #17808

I haven't run it before - but I believe this Ruby tool can be used to find out which references no longer resolve - https://github.com/rapid7/metasploit-framework/blob/e2e8568860e381fc09e1ecedd5ddfc6fdfa3ce99/tools/modules/module_reference.rb

For the Secunia PR I used the waybackmachine API to find new references to use - curl --silent 'http://archive.org/wayback/available?url=http://secunia.com/advisories/27418/&timestamp=20060101' | jq - maybe the tool could be updated with a crude find/replace implementation, or provide an easy way to resolve and update things

Either way, PRs are appreciated if you just want to do ad-hoc PRs instead +1:

dm-ct added a commit to dm-ct/metasploit-framework that referenced this pull request Mar 28, 2023
Both the reference links in this one are dead, replacing with archive.org links.

Much like rapid7#17825, I'll be doing these ad-hoc for a little bit until I figure out a reliable way to do a load of them in one batch.
@adfoster-r7 adfoster-r7 merged commit f626b55 into rapid7:master Mar 28, 2023
@adfoster-r7 adfoster-r7 added the rn-fix release notes fix label Mar 28, 2023
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Mar 28, 2023

Release Notes

Fixes broken documentation references in the exploits/linux/local/zimbra_slapper_priv_esc module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants