Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken module references #17844

Merged

Conversation

SubcomandanteMeowcos
Copy link
Contributor

doing these "by domain" now, piecemeal-ish

I was going to submit one PR per module changed, but lets be real, there are like a thousand or so dead links in the MSF codebase and I don't think R7 employees want to review 1000 PR's that each contain like, a one line change.

this PR fixes all broken references to the "insecurety.net" website, which is long dead and won't be coming back, as the writers lost the domain.

the archiving of references will continue.

doing these "by domain" now, piecemeal.

this PR fixes all broken references to the "insecurety" website, which is long dead.
@bcoles
Copy link
Contributor

bcoles commented Apr 1, 2023

I was going to submit one PR per module changed, but
I don't think R7 employees want to review 1000 PR's that each contain like, a one line change.

Correct.

lets be real, there are like a thousand or so dead links in the MSF codebase

I would be surprised if more than a thousand module reference URLs were dead links unless a major data source changed their URL format (looking at you Microsoft). There was some work performed just over a year ago (#16093) to remove dead links and fix a lot of redirects.

@bcoles bcoles added the docs label Apr 1, 2023
@SubcomandanteMeowcos
Copy link
Contributor Author

SubcomandanteMeowcos commented Apr 2, 2023

I basically started by rerunning the script mentioned in that piece of work, and theres... theres still a lot of dead links, the script alone returned over a thousand.

one of the worst offenders is Oracle, a lot of links to their advisories return a "soft 404" and such :/

My goal is to fix all of the dead links by replacing them with working archive ones, because I personally find it extremely annoying when the module refs point to a dead site.

@bcoles
Copy link
Contributor

bcoles commented Apr 2, 2023

My goal is to fix all of the dead links by replacing them with working archive ones

Better you than me. Good luck.

@adfoster-r7
Copy link
Contributor

An automated solution that modifies the script mentioned in #17825 (comment) to handle the 404s and offer autocorrections to search for webarchive replacement links from their API might be a good middleground

The soft 404s would unfortunately have to be handled on a per-case basis, but depending on the responses you're getting back a generic regex or three might catch the soft 404 responses like <title>404 -.*

@adfoster-r7
Copy link
Contributor

@msjenkins-r7 retest this please.

@adfoster-r7 adfoster-r7 merged commit 2b90337 into rapid7:master Apr 3, 2023
@adfoster-r7 adfoster-r7 added the rn-fix release notes fix label Apr 3, 2023
@adfoster-r7
Copy link
Contributor

Release Notes

Fixes broken documentation references in the secretsdump, zemra_panel_rce, and windows/gather/credentials/skype modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs rn-fix release notes fix
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants