-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use length for freeing. #18076
Conversation
MSDN says this will never succeed - should always be zero.
Removing the breaking change label, since it looks like the |
I was able to reproduce the original issue and validate that the proposed changes fix it. Before
After
|
Release NotesThis fixes a bug in the Windows Meterpreter's memory free API. |
This is the associated PR to rapid7/metasploit-payloads#656.
The call can never succeed with anything other than 0, so we shouldn't provide users the freedom to do the wrong thing.
Created as a draft for now until the new version of metasploit-payloads is built and ready to be referenced.