Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote webservice deletion notice #18440

Merged

Conversation

adfoster-r7
Copy link
Contributor

#18439

Verification

When running msfdb init --component webservice or msfdb init --component webservice the user should be prompted:

$ bundle exec ruby ./msfdb init --component webservice
Running the 'init' command for the webservice:
[WARNING] The remote web service is being removed. Does this impact you? React here: https://github.com/rapid7/metasploit-framework/issues/18439
[WARNING] The remote web service is being removed. Does this impact you? React here: https://github.com/rapid7/metasploit-framework/issues/18439
[WARNING] The remote web service is being removed. Does this impact you? React here: https://github.com/rapid7/metasploit-framework/issues/18439
[?] Initial MSF web service account username? [user]: 

@adfoster-r7 adfoster-r7 force-pushed the add-remote-webservice-deletion-notice branch from 2a5ff1a to edfa1e6 Compare October 31, 2023 22:46
@adfoster-r7 adfoster-r7 marked this pull request as ready for review November 6, 2023 11:12
@cgranleese-r7
Copy link
Contributor

Looks good to me 👍

msfdb init --component webservice
image

@cgranleese-r7 cgranleese-r7 self-assigned this Nov 10, 2023
@cgranleese-r7 cgranleese-r7 merged commit 6659684 into rapid7:master Nov 10, 2023
34 checks passed
@smcintyre-r7 smcintyre-r7 added the rn-enhancement release notes enhancement label Nov 17, 2023
@smcintyre-r7
Copy link
Contributor

Release Notes

This alerts users that the remote web service will be removed. It prompts them to respond to an issue on GitHub if the removal will affect them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-enhancement release notes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants